dash: Skip animations while the overview is hidden

If a window is closed, the list of running applications may change
while the overview is hidden. Animating dash changes is pointless
in this case, so update the dash without animations in that case.

https://bugzilla.gnome.org/show_bug.cgi?id=636156

diff --git a/js/ui/dash.js b/js/ui/dash.js
index 6417ebb01ddd5a0313c7380d4e85a005c109b327..0456de86b226ffd63bd2780eb133a91489ed1e8a 100644 (file)
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -575,9 +575,18 @@ Dash.prototype = {
         for (let i = 0; i < removedActors.length; i++) {
             removedActors[i].show();
             let item = removedActors[i]._delegate;
-            item.animateOutAndDestroy();
+
+            // Don't animate item removal when the overview is hidden
+            if (Main.overview.visible)
+                item.animateOutAndDestroy();
+            else
+                item.actor.destroy();
         }
 
+        // Don't animate item addition when the overview is hidden
+        if (!Main.overview.visible)
+            return;
+
         for (let i = 0; i < addedItems.length; i++)
             addedItems[i].item.animateIn();
     },